-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list-box): reset multiselect selection count position #5405
fix(list-box): reset multiselect selection count position #5405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your quick fix @emyarod!
Deploy preview for carbon-elements ready! Built with commit 599a1f8 |
Deploy preview for carbon-components-react ready! Built with commit 599a1f8 https://deploy-preview-5405--carbon-components-react.netlify.com |
looks like a11y tests are timing out? |
49fa401
to
4bdee12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aagonzales that's because in storybook we're setting an arbitrary 300px width on the component container. if I remove the rule entirely we would end up with something like this for the non-inline multiselect (similar to the text input story) if that's alright otherwise I can just bump up the container width but depending on your screen size you would still see the title wrap behavior |
Ok i guess if its just the react storybook where that's happening then leave it (still not an ideal example), I'll just make sure the demo on the website doesn't do that. |
Got a green light to move this to "ready to merge" state - Thanks @emyarod! |
Closes #5404
This PR resets the positioning of the selection counter for multiselects only
Testing / Reviewing
Ensure the selection counter is properly aligned for comboboxes and multiselects